Add expect_offense mark for offense on empty line #8255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8003
Use
^{}
to denote an offense at an empty line inexpect_offense
. This format was suggested by @marcandre in Issue 8003 comment. I think it has the advantage of familiarity with existing^
and^{name}
syntax.Example:
I have enabled pending frozen string literal specs as coverage for this change.
Also corrected which line the offense is added to in the frozen string literal
specs (always the first line). As the first line is non-empty in some of these
cases, a normal caret
^
is used to mark the offense.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.