Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8252] Fix a typo for --safe-auto-correct command line option #8254

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jul 7, 2020

Fixes #8252.

This PR fixes a command line option name from --safe-autocorrect to --safe-auto-correct, which is compatible with RuboCop 0.66 and lower.

Before:

% bundle exec ./exe/rubocop --safe-auto-correct
invalid option: --safe-auto-correct
Did you mean?  safe-autocorrect
For usage information, use --help

After:

% bundle exec ./exe/rubocop --safe-auto-correct
--safe-auto-correct is deprecated; use --auto-correct
Inspecting 1082 files

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…option

Fixes rubocop#8252.

This PR fixes a command line option name from `--safe-autocorrect`
to `--safe-auto-correct`, which is compatible with RuboCop 0.66 and lower.

Before:

```console
% bundle exec ./exe/rubocop --safe-auto-correct
invalid option: --safe-auto-correct
Did you mean?  safe-autocorrect
For usage information, use --help
```

After:

```console
% bundle exec ./exe/rubocop --safe-auto-correct
--safe-auto-correct is deprecated; use --auto-correct
Inspecting 1082 files
```
@bbatsov bbatsov merged commit 4c06394 into rubocop:master Jul 7, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Jul 7, 2020

Thanks!

@koic koic deleted the fix_a_typo_for_safe_auto_correct_option branch July 7, 2020 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--safe-autocorrect typo?
2 participants