Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new AsciiConstants option for Naming/AsciiIdentifiers. #8238

Merged
merged 1 commit into from Jul 5, 2020
Merged

Add new AsciiConstants option for Naming/AsciiIdentifiers. #8238

merged 1 commit into from Jul 5, 2020

Conversation

fatkodima
Copy link
Contributor

Closes #7458

Implementation as suggested in #7459 (comment)

bbatsov
bbatsov approved these changes Jul 5, 2020
View reviewed changes
Copy link
Collaborator

@bbatsov bbatsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@koic koic merged commit 2040b84 into rubocop:master Jul 5, 2020
@koic
Copy link
Member

koic commented Jul 5, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbatsov bbatsov bbatsov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request for Naming/AsciiConstants
3 participants
@fatkodima @koic @bbatsov