Add new Style/RedundantAssignment cop
#8235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool 😄 I didn't test it but I fear your code will erroneously flag the following, right? def foo
bar = something
bar
ensure
something_else(bar)
end |
fatkodima
force-pushed
the
redundant-assignment-before-return
branch
from
6205193
to
99eda9f
Compare
|
@marcandre Oh, wow, great catch! 💪 Changed handling of ensure nodes and added test case for this. |
|
I like the proposed cop. I'm only wondering if we should shorten its name and drop |
fatkodima
force-pushed
the
redundant-assignment-before-return
branch
from
99eda9f
to
19b41e6
Compare
fatkodima
changed the title
Style/RedundantAssignmentBeforeReturn copStyle/RedundantAssignment cop
|
@bbatsov Agreed, I can not imagine too. Stripped that |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7373
Can confirm this is a popular pattern - I have seen those many times. Also I have found 3 offenses in
railscodebase and 1 inrubocops own.This cop finds the pattern recursively, not just as last 2 expressions in method's body.