Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Style/RedundantParentheses with hash literal as first argument to yield #8214

Merged
merged 1 commit into from Jul 1, 2020
Merged

Fix Style/RedundantParentheses with hash literal as first argument to yield #8214

merged 1 commit into from Jul 1, 2020

Conversation

karlwithak
Copy link
Contributor

Fixes #8208

Do not consider the parentheses around a yielded hash literal as redundant.

koic
koic approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Can you rebase with the latest master branch (The changelog has been updated) and squash your commits into one?

@koic koic merged commit c56caa9 into rubocop:master Jul 1, 2020
@koic
Copy link
Member

koic commented Jul 1, 2020

Thanks!

@karlwithak karlwithak deleted the redundant-parens-yield branch July 1, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koic koic koic approved these changes

@rrosenblum rrosenblum rrosenblum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Style/RedundantParentheses should ignore yielding hash literal
3 participants
@karlwithak @koic @rrosenblum