Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #8195] Fix an error for Style/RedundantFetchBlock #8197

Merged
merged 1 commit into from Jun 23, 2020
Merged

[Fix #8195] Fix an error for Style/RedundantFetchBlock #8197

merged 1 commit into from Jun 23, 2020

Conversation

koic
Copy link
Member

@koic koic commented Jun 23, 2020

Fixes #8195

This PR fixes an error for Style/RedundantFetchBlock when using #fetch with empty block.

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic
[Fix rubocop#8195] Fix an error for Style/RedundantFetchBlock
9469ba0 
Fixes rubocop#8195

This PR fixes an error for `Style/RedundantFetchBlock` when using
`#fetch` with empty block.
@koic koic mentioned this pull request Jun 23, 2020
Closed
@bbatsov bbatsov merged commit 207ff6b into rubocop:master Jun 23, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 23, 2020

Thanks!

@koic koic deleted the fix_an_error_for_redundant_fetch_block branch June 23, 2020 12:53
@jonathanhefner jonathanhefner mentioned this pull request Jun 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An error occurred while Style/RedundantFetchBlock cop was inspecting file
2 participants
@koic @bbatsov