Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8179] Fix an infinite correction loop for Layout/MultilineBlockLayout #8180

Commits on Jun 21, 2020

  1. [Fix rubocop#8179] Fix an infinite correction loop for `Layout/Multil…

    …ineBlockLayout`
    
    Fixes rubocop#8179.
    
    This PR fixes an infinite correction loop error for `Layout/MultilineBlockLayout`
    when missing newline before opening parenthesis `(` for block body.
    
    ```ruby
    # frozen_string_literal: true
    
    foo do |o| (
        bar
      )
    end
    ```
    
    ```console
    % rubocop -a --only Layout/MultilineBlockLayout
    Inspecting 1 file
    C
    
    Offenses:
    
    example.rb:3:12: C: [Corrected] Layout/MultilineBlockLayout: Block body
    expression is on the same line as the block start.
    foo do |o| ( ...
               ^
    
    0 files inspected, 1 offense detected, 1 offense corrected
    Infinite loop detected in /Users/koic/src/github.com/koic/rubocop-issues/8179/example.rb.
    /Users/koic/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/rubocop-0.85.1/lib/rubocop/runner.rb:276:in
    `block in iterate_until_no_changes'
    /Users/koic/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/rubocop-0.85.1/lib/rubocop/runner.rb:272:in
    `loop'
    /Users/koic/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/rubocop-0.85.1/lib/rubocop/runner.rb:272:in
    `iterate_until_no_changes'
    /Users/koic/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/rubocop-0.85.1/lib/rubocop/runner.rb:243:in
    `do_inspection_loop'
    /Users/koic/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/rubocop-0.85.1/lib/rubocop/runner.rb:122:in
    `block in file_offenses'
    ```
    koic committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    0248db9 View commit details
    Browse the repository at this point in the history