Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DidYouMean::SpellChecker may not be available #8143

Merged
merged 2 commits into from Jun 12, 2020
Merged

DidYouMean::SpellChecker may not be available #8143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
752bf8e
[Fixes #7979] SpellChecker may not be available
bquorning Jun 12, 2020
56be1d5
Merge branch 'master' into fix-uninitialized-constant-didyoumean-spel…
bbatsov Jun 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -13,6 +13,7 @@
* [#8115](https://github.com/rubocop-hq/rubocop/issues/8115): Fix false negative for `Lint::FormatParameterMismatch` when argument contains formatting. ([@andrykonchin][])
* [#8131](https://github.com/rubocop-hq/rubocop/pull/8131): Fix false positive for `Style/RedundantRegexpEscape` with escaped delimiters. ([@owst][])
* [#8124](https://github.com/rubocop-hq/rubocop/issues/8124): Fix a false positive for `Lint/FormatParameterMismatch` when using named parameters with escaped `%`. ([@koic][])
* [#7979](https://github.com/rubocop-hq/rubocop/issues/7979): Fix "uninitialized constant DidYouMean::SpellChecker" exception. ([@bquorning][])
* [#8098](https://github.com/rubocop-hq/rubocop/issues/8098): Fix a false positive for `Style/RedundantRegexpCharacterClass` when using interpolations. ([@owst][])

## 0.85.1 (2020-06-07)
Expand Down
6 changes: 6 additions & 0 deletions lib/rubocop/name_similarity.rb
View file
Open in desktop
Expand Up @@ -12,6 +12,12 @@ def find_similar_name(target_name, names)
end

def find_similar_names(target_name, names)
# DidYouMean::SpellChecker is not available in all versions of Ruby, and
# even on versions where it *is* available (>= 2.3), it is not always
# required correctly. So we do a feature check first.
# See: https://github.com/rubocop-hq/rubocop/issues/7979
return [] unless defined?(DidYouMean::SpellChecker)
bquorning marked this conversation as resolved.
Show resolved Hide resolved

names = names.dup
names.delete(target_name)

Expand Down