[Fix #8102] Consider class-length instead of block-length for Struct.new #8122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejasbubane
commented
Jun 8, 2020
|
I guess we should also mention this in the docs - I see we haven't done this for classes as well. Probably some examples there would also be useful. |
|
@tejasbubane Ping :-) |
|
@bbatsov Fixed. |
koic
reviewed
Jul 25, 2020
@tejasbubane Can you mention this in the docs? |
|
@tejasbubane It looks like the conflict with the |
|
@bkuhlmann Thanks for the reminder, this slipped between the cracks. @koic I have added documentation notes to the cops. |
bbatsov
reviewed
Aug 27, 2020
bbatsov
reviewed
Aug 27, 2020
|
@bbatsov Changed. |
tejasbubane
force-pushed
the
fix-8102
branch
from
af0c0b2
to
a5bc856
Compare
|
Rebased on master |
marcandre
approved these changes
Sep 29, 2020
tejasbubane
force-pushed
the
fix-8102
branch
from
a5bc856
to
0df2238
Compare
|
@marcandre Done. |
koic
reviewed
Sep 29, 2020
koic
reviewed
Sep 29, 2020
koic
reviewed
Sep 29, 2020
koic
approved these changes
Sep 29, 2020
…Struct.new Closes rubocop#8102
tejasbubane
force-pushed
the
fix-8102
branch
from
0df2238
to
14bc54e
Compare
|
Thank you always! |
|
❤️ thanks @tejasbubane, and @koic for the review! |
koic
added a commit
to rubocop/rubocop-rails
that referenced
this pull request
Sep 30, 2020
Follow rubocop/rubocop#8122. This commit suppresses the following RuboCop's offense. ```console % bundle exec rake (snip) Offenses: lib/rubocop/cop/mixin/index_method.rb:122:80: W: Lint/RedundantCopDisableDirective: Unnecessary disabling of Metrics/BlockLength. Autocorrection = Struct.new(:match, :block_node, :leading, :trailing) do # rubocop:disable Metrics/BlockLength ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 187 files inspected, 1 offense detected, 1 offense auto-correctable RuboCop failed! ```
koic
added a commit
to koic/rubocop
that referenced
this pull request
Oct 1, 2020
Follow rubocop#8122. This PR fixes the following error for `Metrics/ClassLength` when using or assignment (`||=`). ```console % cat example.rb Constant ||= Struct.new {} % bundle exec rubocop --only Layout/ClassLength -d example.rb (snip) Inspecting 1 file Scanning /Users/koic/src/github.com/koic/rubocop-issues/8122/example.rb An error occurred while Metrics/ClassLength cop was inspecting /Users/koic/src/github.com/koic/rubocop-issues/8122/example.rb:1:0. undefined method `class_definition?' for nil:NilClass /Users/koic/src/github.com/rubocop-hq/rubocop/lib/rubocop/cop/metrics/class_length.rb:43:in `on_casgn' /Users/koic/src/github.com/rubocop-hq/rubocop/lib/rubocop/cop/commissioner.rb:99:in `block (2 levels) in trigger_responding_cops' /Users/koic/src/github.com/rubocop-hq/rubocop/lib/rubocop/cop/commissioner.rb:152:in `with_cop_error_handling' /Users/koic/src/github.com/rubocop-hq/rubocop/lib/rubocop/cop/commissioner.rb:98:in `block in trigger_responding_cops' /Users/koic/src/github.com/rubocop-hq/rubocop/lib/rubocop/cop/commissioner.rb:97:in `each' /Users/koic/src/github.com/rubocop-hq/rubocop/lib/rubocop/cop/commissioner.rb:97:in `trigger_responding_cops' /Users/koic/src/github.com/rubocop-hq/rubocop/lib/rubocop/cop/commissioner.rb:70:in `on_casgn' /Users/koic/src/github.com/rubocop-hq/rubocop-ast/lib/rubocop/ast/traversal.rb:60:in `block in on_or_asgn' /Users/koic/src/github.com/rubocop-hq/rubocop-ast/lib/rubocop/ast/traversal.rb:60:in `each' /Users/koic/src/github.com/rubocop-hq/rubocop-ast/lib/rubocop/ast/traversal.rb:60:in `on_or_asgn' /Users/koic/src/github.com/rubocop-hq/rubocop/lib/rubocop/cop/commissioner.rb:72:in `on_or_asgn' /Users/koic/src/github.com/rubocop-hq/rubocop-ast/lib/rubocop/ast/traversal.rb:14:in `walk' /Users/koic/src/github.com/rubocop-hq/rubocop/lib/rubocop/cop/commissioner.rb:85:in `investigate' ``` This PR have also tweaked the highlight area of offense to more eligible location for count the class block length. Before: ```ruby Foo = Class.new do ^^^ Class has too many lines. [6/5] ``` After: ```ruby Foo = Class.new do ^^^^^^^^^^^^ Class has too many lines. [6/5] ``` I haven't added the fixing to the changelog because rubocop#8122 hasn't been released yet.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8102
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.