Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8096] Fix a false positive for Lint/SuppressedException #8097

Conversation

koic
Copy link
Member

@koic koic commented Jun 4, 2020

Fixes #8096

This PR fixes a false positive for Lint/SuppressedException
when empty rescue block in defs.

% cat example.rb
def self.foo
rescue Foo
  # ok
end

% bundle exec rubocop --only Lint/SuppressedException
(snip)

Inspecting 1 file
W

Offenses:

example.rb:2:1: W: Lint/SuppressedException: Do not suppress exceptions.
rescue Foo
^^^^^^^^^^

1 file inspected, 1 offense detected

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Fixes rubocop#8096

This PR fixes a false positive for `Lint/SuppressedException`
when empty rescue block in defs.

```console
% cat example.rb
def self.foo
rescue Foo
  # ok
end

% bundle exec rubocop --only Lint/SuppressedException
(snip)

Inspecting 1 file
W

Offenses:

example.rb:2:1: W: Lint/SuppressedException: Do not suppress exceptions.
rescue Foo
^^^^^^^^^^

1 file inspected, 1 offense detected
```
@bbatsov bbatsov merged commit 1f65829 into rubocop:master Jun 5, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Jun 5, 2020

Thanks!

@koic koic deleted the fix_false_positive_for_lint_suppressed_exception branch June 5, 2020 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Lint/SuppressedException false positive at singleton method def
2 participants