[Fix #8083] Fix an error for Lint/MixedRegexpCaptureTypes
#8093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubocop#8083. This PR fixes an error for `Lint/MixedRegexpCaptureTypes` cop when using a regular expression that cannot be processed by regexp_parser gem. https://github.com/ammar/regexp_parser Probably false negatives will be made, however false negatives will be reduced when a processing pattern of regexp_parser increases. So this PR relies on regexp_parser for error resolution.
koic
force-pushed
the
fix_an_error_for_mixed_regexp_capture_types
branch
from
1ea52fc
to
373423e
Compare
|
Looks good! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8083.
This PR fixes an error for
Lint/MixedRegexpCaptureTypescop when using a regular expression that cannot be processed by regexp_parser gem.https://github.com/ammar/regexp_parser
Probably false negatives will be made, however false negatives will be reduced when a processing pattern of regexp_parser increases.
So this PR relies on regexp_parser for error resolution.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.