Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8081] Fix a false positive for Lint/SuppressedException #8082

Merged

Conversation

koic
Copy link
Member

@koic koic commented Jun 2, 2020

Fixes #8081.

This PR fixes a false positive for Lint/SuppressedException when empty rescue block in do block.

% cat example.rb
foo do
rescue Foo
  # ok
end

% bundle exec rubocop --only Lint/SuppressedException
(snip)

Inspecting 1 file
W

Offenses:

example.rb:2:1: W: Lint/SuppressedException: Do not suppress exceptions.
rescue Foo
^^^^^^^^^^

1 file inspected, 1 offense detected

do block rescue is a syntax introduced in Ruby 2.5.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic force-pushed the fix_false_positive_for_lint_suppressed_exception branch from 7419071 to daeba27 Compare June 3, 2020 23:31
Fixes rubocop#8081.

This PR fixes an error for `Lint/SuppressedException`
when empty rescue block in `do` block.

```console
% cat example.rb
foo do
rescue Foo
  # ok
end

% bundle exec rubocop --only Lint/SuppressedException
(snip)

Inspecting 1 file
W

Offenses:

example.rb:2:1: W: Lint/SuppressedException: Do not suppress exceptions.
rescue Foo
^^^^^^^^^^

1 file inspected, 1 offense detected
```

`do` block rescue is a syntax introduced in Ruby 2.5.
@koic koic force-pushed the fix_false_positive_for_lint_suppressed_exception branch from daeba27 to 00f7941 Compare June 4, 2020 01:20
@koic koic merged commit 502fa4a into rubocop:master Jun 4, 2020
@koic koic deleted the fix_false_positive_for_lint_suppressed_exception branch June 4, 2020 06:19
@koic koic changed the title [Fix #8081] Fix an error for Lint/SuppressedException [Fix #8081] Fix a false positive for Lint/SuppressedException Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: false positive for Lint/SuppressedException in blocks
1 participant