Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec refactoring #8069

Merged
merged 4 commits into from May 31, 2020
Merged

Spec refactoring #8069

merged 4 commits into from May 31, 2020

Commits on May 31, 2020

  1. Remove redundant spec. 

    It tests the same thing as the previous spec; their success is not independent.
See [rubocop#8016]
    @marcandre
    marcandre committed May 31, 2020
    Copy the full SHA
    d36b943 View commit details
    Browse the repository at this point in the history

  2. Make spec closer to reality 

    This spec would fail with the modern implementation...
    @marcandre
    marcandre committed May 31, 2020
    Copy the full SHA
    52de5b0 View commit details
    Browse the repository at this point in the history

  3. Refactor specs for simplicity and better error failures

    @marcandre
    marcandre committed May 31, 2020
    Copy the full SHA
    c92378a View commit details
    Browse the repository at this point in the history

  4. Allow expect_offense to have variables

    @marcandre
    marcandre committed May 31, 2020
    Copy the full SHA
    4e0f9b4 View commit details
    Browse the repository at this point in the history