Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8063] Add new AllowedNames option for Naming/ClassAndModuleCamelCase #8068

Merged
merged 1 commit into from May 31, 2020

Conversation

tejasbubane
Copy link
Contributor

Closes #8063


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@bbatsov
Copy link
Collaborator

bbatsov commented May 31, 2020

You should also extend the cop documentation a bit. One thing that concerns me is that it's not very clear that "AllowedNames" can also just a part of a name (the way the code is currently written). I'm not sure I like this, as this adds ambiguity. Better docs or a clearer approach are the way to go here.

@tejasbubane
Copy link
Contributor Author

@bbatsov Added config info to cop documentation & default.yml.

@bbatsov
Copy link
Collaborator

bbatsov commented May 31, 2020

I see the docs check task is failing. Looking at the diff you made some changes to the cop docs, but didn't run the docs update rake task afterwards.

@tejasbubane tejasbubane force-pushed the fix-8063 branch 3 times, most recently from 940845f to c34df40 Compare May 31, 2020 09:23
@bbatsov
Copy link
Collaborator

bbatsov commented May 31, 2020

I'm afraid you'll have to rebase again. Too much dev activity today. :-)

@bbatsov bbatsov merged commit 9ffd1cc into rubocop:master May 31, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented May 31, 2020

Victory! 😆 Thanks for the quick reaction! 🙇‍♂️

@tejasbubane tejasbubane deleted the fix-8063 branch May 31, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive in Naming/ClassAndModuleCamelCase when using module_parent
2 participants