[Fix #7971] Fix --disable-uncorrectable not updating uncorrected code #8054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't qute correct. My PR helps in detecting non-corrections, but you're right that they should be then disabled. I'm 👍 to merge (but you need to resolve/disable the "metrics/" offenses 🙄) |
rrosenblum
force-pushed
the
7971_disable_uncorrected
branch
from
142eb3c
to
800d653
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7971.
I still need to decide how to handle the failing metrics in
cop.rb. I know @marcandre mentioned that #7868 will make this easier/change the way this would work. I haven't had a chance to look over that PR.There are a few more things that I still want to look into with
--disable-uncorrectable. I'm curious how well it works on lines that already contain a differentrubocop:todoorrubocop:disablecomment.