Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Lint::FormatParameterMismatch cop #8042

Merged
merged 2 commits into from Jun 7, 2020
Merged

Fix Lint::FormatParameterMismatch cop #8042

merged 2 commits into from Jun 7, 2020

Commits on Jun 7, 2020

  1. Fix Lint::FormatParameterMismatch cop 

    The cop failed to process format string in invalid format and raised exception. There are several cases when format string contains valid segments but these segments aren't compatible.

For instance numbered format cannot be mixed with unnumbered or named. Such format string will lead to ArgumentError when code is executed but sometimes it's needed e.g. in tests to check how the code such invalid format strings.
    @andrykonchin
    andrykonchin committed Jun 7, 2020
    Copy the full SHA
    3d2be12 View commit details
    Browse the repository at this point in the history

  2. Add offense to Lint::FormatParameterMismatch about invalid format string

    @andrykonchin
    andrykonchin committed Jun 7, 2020
    Copy the full SHA
    b11f071 View commit details
    Browse the repository at this point in the history