Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better separation of concerns between Team and Commissioner #8030

Merged
merged 5 commits into from May 26, 2020
Merged

Better separation of concerns between Team and Commissioner #8030

merged 5 commits into from May 26, 2020

Commits on May 26, 2020

  1. Team.new => Team.mobilize; Team.new now accepts cop instances instead… 

    … of classes
    @marcandre
    marcandre committed May 26, 2020
    Configuration menu
    Copy the full SHA
    66c95b5 View commit details
    Browse the repository at this point in the history

  2. Simplify cop_helper

    @marcandre
    marcandre committed May 26, 2020
    Configuration menu
    Copy the full SHA
    b0a6db1 View commit details
    Browse the repository at this point in the history

  3. Avoid unneeded yield form. 

    Congrats to Metrics/AbcSize thinking this code is more complicated than before
    @marcandre
    marcandre committed May 26, 2020
    Configuration menu
    Copy the full SHA
    dc814d8 View commit details
    Browse the repository at this point in the history

  4. Excluding non-relevant cops is a duty of Team, not Commissioner. 

    Before this commit:
* a second call to `Commissioner#investigate` could be missing a cop that was excluded previously
* a force might be added by Team for a single cop that is later judged to be non relevant by Commissioner
  but the later can't exclude the force now
* cops judged not relevant by the Commissioner were still processed (e.g. in autocorrect_all_cops)
    @marcandre
    marcandre committed May 26, 2020
    Configuration menu
    Copy the full SHA
    305abba View commit details
    Browse the repository at this point in the history

  5. Refactor Commissioner specs

    @marcandre
    marcandre committed May 26, 2020
    Configuration menu
    Copy the full SHA
    a8f5223 View commit details
    Browse the repository at this point in the history