Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #8005] Always inspect anonymous sources #8028

Merged
merged 1 commit into from May 25, 2020

Conversation

eugeneius
Copy link
Contributor

Fixes #8005.

When using the expect_offense and expect_no_offenses spec helpers, the processed source is given the special filename "(string)", unless a mock filename is passed as its second argument.

Since #7970, the default configuration for the cop under test is loaded when using the config shared context. If this configuration features an Include key, expect_offense won't work unless a matching mock filename is specified.

Instead of forcing specs for cops with a default Include configuration to do that, I think we can always inspect anonymous sources.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

When using the `expect_offense` and `expect_no_offenses` spec helpers,
the processed source is given the special filename "(string)", unless a
mock filename is passed as its second argument.

Since 3c91822 the default configuration
for the cop under test is loaded when using the `config` shared context.
If this configuration features an `Include` key, `expect_offense` won't
work unless a matching mock filename is specified.

Instead of forcing specs for cops with a default `Include` configuration
to do that, I think we can always inspect anonymous sources.
@koic koic merged commit 42ea792 into rubocop:master May 25, 2020
@koic
Copy link
Member

koic commented May 25, 2020

Brilliant! Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RuboCop Rails build fails
2 participants