[Fix #8012] Fix incorrect autocorrect for Lint/DeprecatedOpenSSLConstant
#8014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SSLConstant` Fixes rubocop#8012. This PR fixes an incorrect autocorrect for `Lint/DeprecatedOpenSSLConstant` when deprecated OpenSSL constant is used in a block.
|
@koic any chance when this gets merged we could get a 0.84.1 release? I'd really like to enable this one for our linting tool, but all the cases I've hit so far are in blocks. |
|
@tas50 I'll think about this. I might cut a bugfix release if more fixes accumulate over the weekend. In the mean time it's easy to just build the gem straight from GitHub. |
koic
deleted the
fix_incorrect_autocorrect_for_deprecated_open_ssl_constant
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8012.
This PR fixes an incorrect autocorrect for
Lint/DeprecatedOpenSSLConstantwhen deprecated OpenSSL constant is used in a block.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.