[Fix #8008] Fix an error for Lint/SuppressedException
#8010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubocop#8008. This PR fixes an error for `Lint/SuppressedException` when empty rescue block in `def`.
|
Thanks! |
This was referenced May 22, 2020
|
Any chance this could go into a 0.84.1 quick release ? |
doudou
added a commit
to rock-core/package_set
that referenced
this pull request
May 30, 2020
rubocop 0.84 has a bug that triggers on tools/roby. It's already fixed, but it does not seem it's enough to trigger a quick release. Reference: rubocop/rubocop#8010 Since it breaks CI, stick to 0.83 until a fixed version gets released.
doudou
added a commit
to rock-core/package_set
that referenced
this pull request
May 30, 2020
rubocop 0.84 has a bug that triggers on tools/roby. It's already fixed, but it does not seem it's enough to trigger a quick release. Reference: rubocop/rubocop#8010 Since it breaks CI, stick to 0.83 until a fixed version gets released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8008.
This PR fixes an error for
Lint/SuppressedExceptionwhen empty rescue block indef.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.