[Fix #7993] Fix a false positive for Migration/DepartmentName
#7995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rubocop#7993. This PR fixes a false positive for `Migration/DepartmentName` cop when a disable comment contains an unexpected character for department name.
koic
force-pushed
the
fix_false_positive_for_migration_department_name
branch
from
391bb09
to
179bb78
Compare
|
Probably we should also be more explicit in the docs that users should not add anything besides the name. Maybe even register some offence in such case. |
|
Sure. I've mentioned the issue to manual/configuration.md. And we may be able to add a new cop for disabling comment style If RuboCop expects to make this strict. |
|
Thanks! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7993.
This PR fixes a false positive for
Migration/DepartmentNamecop when a disable comment contains an unexpected character for department name.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.