Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #7991] Fix an error for Layout/EmptyLinesAroundAttributeAccessor #7992

Conversation

koic
Copy link
Member

@koic koic commented May 18, 2020

Fixes #7991.

This PR fixes an error for Layout/EmptyLinesAroundAttributeAccessor when attribute method is method chained.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

…Accessor`

Fixes rubocop#7991.

This PR fixes an error for `Layout/EmptyLinesAroundAttributeAccessor`
when attribute method is method chained.
@bbatsov bbatsov merged commit 3651d6b into rubocop:master May 19, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented May 19, 2020

Thanks!

@koic koic deleted the fix_error_for_empty_lines_around_attribute_accessor branch May 19, 2020 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout/EmptyLinesAroundAttributeAccessor fails with error when variable with name attr is used
2 participants