Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resolving inherit_gem in remote configs #7990

Merged
merged 1 commit into from May 26, 2020
Merged

Fix resolving inherit_gem in remote configs #7990

merged 1 commit into from May 26, 2020

Commits on May 25, 2020

  1. Fix resolving inherit_gem in remote configs 

    When a file inherits from a url inheriting from a gem, like so:

```yaml
# .rubocop.yml
inherit_from: http://example.com/default.yml
```

```yaml
# http://example.com/default.yml
inherit_gem:
    somegem: default.yml
```

```yaml
# somegem's default.yml
Layout/LineLength:
    Max: 48
```

Rubocop would then incorrectly try to resolve a URL like this:

`http://example.com//private/var/folders/69/bjrqv8v1225f7yqnxknm3fb80000gn/T/d20200518-94245-6dqeew/work/gems/somegem/default.yml`

With this change, local gem paths are no longer taken by mistake for relative remote paths.
    @CvX
    CvX committed May 25, 2020
    Copy the full SHA
    f08165d View commit details
    Browse the repository at this point in the history