Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VersionChanged from 1.0 to 0.84 #7986

Merged

Conversation

koic
Copy link
Member

@koic koic commented May 17, 2020

Follow up to #7985 (comment).

RuboCop 0.84 will be cut before RuboCop 1.0.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Follow up to rubocop#7985 (comment).

RuboCop 0.84 will be cut before RuboCop 1.0.
@bbatsov bbatsov merged commit 0cee06f into rubocop:master May 17, 2020
@koic koic deleted the update_version_changed_from_1_0_to_0_84 branch May 17, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants