New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option OnlyFor
to the Bundler/GemComment
cop.
#7978
Merged
bbatsov
merged 21 commits into
rubocop:master
from
ric2b:gem-comment-cop-add-pinned-only-option
May 31, 2020
Merged
Changes from 6 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c3bfc90
Add tests for the new configuration.
ric2b 91e6211
Update the cop to support 'OnlyIfVersionRestricted' configuration.
ric2b c1c90df
Update the cop's documentation.
ric2b acab071
Update docs.
ric2b e7ed684
Update CHANGELOG.md
ric2b c64c375
Fix documentation mistakes.
ric2b db46a0f
Generalize the configuration and support checking keyword arguments.
ric2b 638178d
Update docs and changelog.
ric2b 1cfcb73
Fix typo in changelog update.
ric2b 3323708
Simplify `version_specified_gem?`
ric2b 4153cd9
Update test context name to be more consistent
ric2b d52e515
Update test context name to be more consistent
ric2b 7769628
Clarify `checked_options_present?` boolean expression
ric2b cd3e921
Use more rspec contexts to make test cases more readable.
ric2b dd9ec11
Merge branch 'master' into gem-comment-cop-add-pinned-only-option
ric2b c4bcc3a
Merge branch 'master' into gem-comment-cop-add-pinned-only-option
ric2b 0f9be81
Merge remote-tracking branch 'origin/master' into gem-comment-cop-add…
ric2b 4ffcb8b
update documentation
ric2b e5597a6
Simplify option names and update version changed to 0.85.
ric2b a308431
Add common options and link to bundler documentation.
ric2b 965c6bd
Merge branch 'master' into gem-comment-cop-add-pinned-only-option
ric2b File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also expand the cop summary.