Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #7962] Fix a false positive for Lint/ParenthesesAsGroupedExpression #7963

Merged
merged 1 commit into from May 13, 2020
Merged

[Fix #7962] Fix a false positive for Lint/ParenthesesAsGroupedExpression #7963

merged 1 commit into from May 13, 2020

Conversation

koic
Copy link
Member

@koic koic commented May 13, 2020

Fixes #7962.

This PR fixes the following false positive for Lint/ParenthesesAsGroupedExpression when heredoc has a space between the same string as the method name and (.

foo(
  <<~EOS
    foo (
    )
  EOS
)

This PR adds a reproduction test and reverts a required logic removed by #7909.

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic
[Fix rubocop#7962] Fix a false positive for `Lint/ParenthesesAsGroupe…
56fe59e 
…dExpression`

Fixes rubocop#7962.

This PR fixes the following false positive for `Lint/ParenthesesAsGroupedExpression`
when heredoc has a space between the same string as the method name and `(`.

```ruby
foo(
  <<~EOS
    foo (
    )
  EOS
)
```

This PR adds a reproduction test and reverts a required logic removed by rubocop#7909.
@bbatsov bbatsov merged commit 6aa1a00 into rubocop:master May 13, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented May 13, 2020

Thanks!

@koic koic deleted the fix_false_positive_for_parentheses_as_grouped_expression branch May 13, 2020 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in 0.83.0: ParenthesesAsGroupedExpression for heredoc
2 participants
@koic @bbatsov