Add required Ruby version to generated cops manual #7947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
May 9, 2020
manual/cops_lint.md
Outdated
| @@ -657,6 +657,8 @@ end | |||
|
|
|||
| ## Lint/ErbNewArguments | |||
|
|
|||
| Required Ruby version: 2.6 | |||
There was a problem hiding this comment.
We have admonitions enabled and this seems like a good use for them. You can some !!! Note prefix to this to turn it into an admonition.
There was a problem hiding this comment.
Great suggestion! This prefix feature is what I wanted thing :-)
I updated this one. Thank you always!
Follow up to rubocop#7921 (comment). This PR adds required Ruby version to cops manual generated by `rake generate_cops_documentation`.
koic
force-pushed
the
add_required_ruby_version_to_cops_manual
branch
from
134e85d
to
a7e3299
Compare
koic
added a commit
to koic/rubocop-performance
that referenced
this pull request
May 21, 2020
8 tasks
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
May 21, 2020
8 tasks
renawatson68
added a commit
to renawatson68/performance-develop-rubyonrails
that referenced
this pull request
Sep 23, 2022
richardstewart0213
added a commit
to richardstewart0213/performance-build-Performance-optimization-analysis-
that referenced
this pull request
Nov 4, 2022
MarttiCheng
added a commit
to MarttiCheng/Rubocop-Performance
that referenced
this pull request
Sep 28, 2023
SerhiiMisiura
added a commit
to SerhiiMisiura/Rubocop-Performance
that referenced
this pull request
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #7921 (comment).
This PR adds required Ruby version to cops manual generated by
rake generate_cops_documentation.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.