Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #7936] Mark as Lint/BooleanSymbol unsafe #7941

Merged
merged 1 commit into from May 10, 2020
Merged

[Fix #7936] Mark as Lint/BooleanSymbol unsafe #7941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -27,6 +27,7 @@
* [#7860](https://github.com/rubocop-hq/rubocop/issues/7860): Change `AllowInHeredoc` option of `Layout/TrailingWhitespace` to `true` by default. ([@koic][])
* [#7094](https://github.com/rubocop-hq/rubocop/issues/7094): Clarify alignment in `Layout/MultilineOperationIndentation`. ([@jonas054][])
* [#7390](https://github.com/rubocop-hq/rubocop/issues/7390): **(Breaking)** Enabling a cop overrides disabling its department. ([@jonas054][])
* [#7936](https://github.com/rubocop-hq/rubocop/issues/7936): Mark `Lint/BooleanSymbol` as unsafe. ([@laurmurclar][])

## 0.82.0 (2020-04-16)

Expand Down Expand Up @@ -4487,3 +4488,4 @@
[@DracoAter]: https://github.com/DracoAter
[@diogoosorio]: https://github.com/diogoosorio
[@jeffcarbs]: https://github.com/jeffcarbs
[@laurmurclar]: https://github.com/laurmurclar
3 changes: 2 additions & 1 deletion config/default.yml
View file
Open in desktop
Expand Up @@ -1342,8 +1342,9 @@ Lint/BigDecimalNew:
Lint/BooleanSymbol:
Description: 'Check for `:true` and `:false` symbols.'
Enabled: true
Safe: false
VersionAdded: '0.50'
VersionChanged: '0.81'
VersionChanged: '0.83'

Lint/CircularArgumentReference:
Description: "Default values in optional keyword arguments and optional ordinal arguments should not refer back to the name of the argument."
Expand Down
2 changes: 1 addition & 1 deletion manual/cops_lint.md
View file
Open in desktop
Expand Up @@ -166,7 +166,7 @@ BigDecimal(123.456, 3)

Enabled by default | Safe | Supports autocorrection | VersionAdded | VersionChanged
--- | --- | --- | --- | ---
Enabled | Yes | Yes | 0.50 | 0.81
Enabled | No | Yes (Unsafe) | 0.50 | 0.83

This cop checks for `:true` and `:false` symbols.
In most cases it would be a typo.
Expand Down