Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use did_you_mean instead of jaro_winkler #7931

Merged
merged 4 commits into from May 10, 2020
Merged

Use did_you_mean instead of jaro_winkler #7931

merged 4 commits into from May 10, 2020
+19 −99

Commits on May 10, 2020

  1. Simplify NameSimilarity.find_similar_name 

    By explicitly passing the collection of "possible names" when calling
`NameSimilarity.find_similar_name`, the calling class doesn't need to
implement a `.collect_variable_like_names` method.
    @bquorning
    bquorning committed May 10, 2020
    Copy the full SHA
    6d6c227 View commit details
    Browse the repository at this point in the history

  2. Change find_similar_name to a module_function 

    Change `NameSimilarity#find_similar_name` into
`NameSimilarity.find_similar_name`, since it no longer needs to call
back to a method in the same context.
    @bquorning
    bquorning committed May 10, 2020
    Copy the full SHA
    cabda37 View commit details
    Browse the repository at this point in the history

  3. Use DidYouMean 

    Simplify `NameSimilarity#find_similar_name` by using the built-in
`did_you_mean` gem instead of `StringUtil.similarity`.
    @bquorning
    bquorning committed May 10, 2020
    Copy the full SHA
    84ee8db View commit details
    Browse the repository at this point in the history

  4. Remove dependency on jaro_winkler 

    Removing `StringUtil` as well, by adding a
`NameSimilarity.find_similar_names` method.
    @bquorning
    bquorning committed May 10, 2020
    Copy the full SHA
    332e66b View commit details
    Browse the repository at this point in the history