[Fix #3696] Add AllowComments option to Lint/EmptyWhen cop
#7907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
add_allow_comments_to_lint_empty_when
branch
from
2784dc2
to
18d8cde
Compare
bbatsov
approved these changes
May 10, 2020
Fixes rubocop#3696 and rubocop#3754. This PR add `AllowComments` option to `Lint/EmptyWhen` cop. This option is enabled by default based on user feedback. It is also the same default as the option of `Lint/SuppressedException` set in rubocop#7805.
koic
force-pushed
the
add_allow_comments_to_lint_empty_when
branch
from
18d8cde
to
f5917d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3696 and #3754.
This PR add
AllowCommentsoption toLint/EmptyWhencop.This option is enabled by default based on user feedback. It is also the same default as the option of
Lint/SuppressedExceptionset in #7805.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.