[Fix #7899] Fix an infinite loop error for Layout/SpaceAroundOperators
#7901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_an_infinite_loop_error_for_space_around_operators
branch
from
ee4389b
to
f1ca186
Compare
bbatsov
reviewed
Apr 24, 2020
| @@ -170,6 +170,19 @@ def offense(type, operator, with_space, right_operand) | |||
| yield msg if msg | |||
| end | |||
|
|
|||
| def enclose_operator_in_space(corrector, range) | |||
There was a problem hiding this comment.
I think it's enclose_with, not enclose_in.
There was a problem hiding this comment.
I updated this method name. Thank you!
…Operators` Fixes rubocop#7899. This PR fixes the following infinite loop error for `Layout/SpaceAroundOperators` with `Layout/ExtraSpacing` when using `ForceEqualSignAlignment: true`. ```console % bundle exec rubocop -V 0.82.0 (using Parser 2.7.1.1, running on ruby 2.7.0 x86_64-darwin17) % cat .rubocop.yml Layout/ExtraSpacing: ForceEqualSignAlignment: true % cat example.rb test123456 = nil test1234 = nil test1_test2_test3_test4_12 =nil % bundle exec rubocop -a --only Layout/ExtraSpacing,Layout/SpaceAroundOperators (snip) Infinite loop detected in /Users/koic/src/github.com/koic/rubocop-issues/7899/example.rb. /Users/koic/src/github.com/rubocop-hq/rubocop/lib/rubocop/runner.rb:287:in `check_for_infinite_loop' /Users/koic/src/github.com/rubocop-hq/rubocop/lib/rubocop/runner.rb:270:in `block in iterate_until_no_changes' /Users/koic/src/github.com/rubocop-hq/rubocop/lib/rubocop/runner.rb:269:in `loop' /Users/koic/src/github.com/rubocop-hq/rubocop/lib/rubocop/runner.rb:269:in `iterate_until_no_changes' ```
koic
force-pushed
the
fix_an_infinite_loop_error_for_space_around_operators
branch
from
f1ca186
to
8329663
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7899.
This PR fixes the following infinite loop error for
Layout/SpaceAroundOperatorswithLayout/ExtraSpacingwhen usingForceEqualSignAlignment: true.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.