[Fix #7635] Fix a false positive for Style/MultilineWhenThen
#7889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_a_false_positive_for_multiline_when_then
branch
from
ebf386b
to
31d2388
Compare
bbatsov
reviewed
Apr 19, 2020
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ | |||
| * [#7882](https://github.com/rubocop-hq/rubocop/pull/7882): Fix `Style/CaseEquality` when `AllowOnConstant` is `true` and the method receiver is implicit. ([@rafaelfranca][]) | |||
| * [#7790](https://github.com/rubocop-hq/rubocop/issues/7790): Fix `--parallel` and `--ignore-parent-exclusion` combination. ([@jonas054][]) | |||
| * [#7881](https://github.com/rubocop-hq/rubocop/issues/7881): Fix `--parallel` and `--force-default-config` combination. ([@jonas054][]) | |||
| * [#7635](https://github.com/rubocop-hq/rubocop/issues/7635): Fix a false positive for `Style/MultilineWhenThen` when a `when` body has multiple lines with breakline. ([@koic][]) | |||
There was a problem hiding this comment.
I don't quite get "multiple lines with breakline". Don't you always have line breaks in something that's multiline?
There was a problem hiding this comment.
Ah... this is a strange sentence 💦 I updated the sentence to:
"when then required for a body of when is used."
koic
force-pushed
the
fix_a_false_positive_for_multiline_when_then
branch
from
31d2388
to
f2daeed
Compare
|
I think it's also a good idea to mention this in the "good" examples in the cop's documentation, as technically it's a multi-line |
Fixes rubocop#7635 This PR fixes a false positive for `Style/MultilineWhenThen` when `then` required for a body of `when` is used.
koic
force-pushed
the
fix_a_false_positive_for_multiline_when_then
branch
from
f2daeed
to
dbef91d
Compare
|
That idea seems reasonable 🌟 I added a good example for this case. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7635
This PR fixes a false positive for
Style/MultilineWhenThenwhenthenrequired for a body ofwhenis used.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.