Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Ruby 2.3 #7869

Merged
merged 1 commit into from Apr 12, 2020
Merged

Commits on Apr 12, 2020

  1. Drop support for Ruby 2.3

    ### Summary
    
    This PR drops support for Ruby 2.3.
    
    It is discussed in rubocop#6945.
    And this suggestion would mean that RuboCop 1.0 (and pre-release)
    requires Ruby 2.4 or higher.
    
    The following is a plan after this PR.
    There was a build error report for a dependent jaro_winkler gem.
    rubocop#5989, rubocop#6754, rubocop#7447, and rubocop#7564. And rubocop#7673 was trying to solve it.
    
    After dropping Ruby 2.3, replace jaro_winkler with did_you_mean.
    did_you_mean is written in Ruby, so the build error due to native
    extensions no longer occur. That change opens as anther PR.
    
    ### Other Information
    
    The latest did_you_mean (1.4.0) supports Ruby 2.5 or higher,
    so it needs to be confirmed old versions it works with Ruby 2.4.
    koic committed Apr 12, 2020
    Copy the full SHA
    aa85bcd View commit details
    Browse the repository at this point in the history