Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for tabs in indentation. #7867

Merged
merged 7 commits into from Apr 15, 2020
Merged

Add support for tabs in indentation. #7867

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4207896
Add support for tabs indentation.
DracoAter Apr 11, 2020
f2e7a1b
Change SupportedStyles for Layout/Tab to [spaces, tabs]. Fix linting …
DracoAter Apr 11, 2020
a15f80d
Rename Layout/Tab cop into Layout/IndentationStyle.
DracoAter Apr 13, 2020
d95f65f
Add relnotes and changelog entries. Add renamed cop into RENAMED_COPS…
DracoAter Apr 14, 2020
6c0194a
Merge remote-tracking branch 'upstream/master'
DracoAter Apr 14, 2020
d6cdf0b
Merge master.
DracoAter Apr 14, 2020
b8c2b44
Fix changelog entries.
DracoAter Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -4,8 +4,13 @@

### New features

* [#7867](https://github.com/rubocop-hq/rubocop/issues/7867): Add support for tabs in indentation. ([@DracoAter][])
koic marked this conversation as resolved.
Show resolved Hide resolved
* [#7850](https://github.com/rubocop-hq/rubocop/issues/7850): Make it possible to enable/disable pending cops. ([@koic][])

### Changes

* Renamed `Layout/Tab` cop to `Layout/IndentationStyle` ([@DracoAter][])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a **(Breaking)** prefix here.


### Bug fixes

* [#7842](https://github.com/rubocop-hq/rubocop/issues/7842): Fix a false positive for `Lint/RaiseException` when raising Exception with explicit namespace. ([@koic][])
Expand Down Expand Up @@ -4438,3 +4443,4 @@
[@dmolesUC]: https://github.com/dmolesUC
[@yuritomanek]: https://github.com/yuritomanek
[@egze]: https://github.com/egze
[@DracoAter]: https:/github.com/DracoAter
2 changes: 1 addition & 1 deletion config/default.yml
View file
Open in desktop
Expand Up @@ -806,7 +806,7 @@ Layout/IndentationStyle:
StyleGuide: '#spaces-indentation'
Enabled: true
VersionAdded: '0.49'
VersionChanged: '0.51'
VersionChanged: '0.82'
# By default, the indentation width from Layout/IndentationWidth is used
# But it can be overridden by setting this parameter
# It is used during auto-correction to determine how many spaces should
Expand Down
1 change: 1 addition & 0 deletions lib/rubocop/config_obsoletion.rb
View file
Open in desktop
Expand Up @@ -17,6 +17,7 @@ class ConfigObsoletion
'Layout/IndentHash' => 'Layout/FirstHashElementIndentation',
'Layout/IndentHeredoc' => 'Layout/HeredocIndentation',
'Layout/LeadingBlankLines' => 'Layout/LeadingEmptyLines',
'Layout/Tab' => 'Layout/IndentationStyle',
'Layout/TrailingBlankLines' => 'Layout/TrailingEmptyLines',
'Lint/DuplicatedKey' => 'Lint/DuplicateHashKey',
'Lint/EndInMethod' => 'Style/EndBlock',
Expand Down
9 changes: 9 additions & 0 deletions relnotes/v0.82.0.md
View file
Open in desktop
@@ -0,0 +1,9 @@
### New features

* [#7867](https://github.com/rubocop-hq/rubocop/issues/7867): Add support for tabs in indentation. ([@DracoAter][])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is auto-generated on release from the changelog. You shouldn't update it manually.


### Changes

* Renamed `Layout/Tab` cop to `Layout/IndentationStyle` ([@DracoAter][])

[@DracoAter]: https:/github.com/DracoAter
3 changes: 3 additions & 0 deletions spec/rubocop/config_obsoletion_spec.rb
View file
Open in desktop
Expand Up @@ -29,6 +29,7 @@
'Layout/IndentHash' => { 'Enabled': true },
'Layout/IndentHeredoc' => { 'Enabled': true },
'Layout/LeadingBlankLines' => { 'Enabled': true },
'Layout/Tab' => { 'Enabled': true },
'Layout/TrailingBlankLines' => { 'Enabled': true },
'Lint/DuplicatedKey' => { 'Enabled': true },
'Lint/HandleExceptions' => { 'Enabled': true },
Expand Down Expand Up @@ -108,6 +109,8 @@
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Layout/LeadingBlankLines` cop has been renamed to `Layout/LeadingEmptyLines`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Layout/Tab` cop has been renamed to `Layout/IndentationStyle`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Layout/TrailingBlankLines` cop has been renamed to `Layout/TrailingEmptyLines`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Lint/DuplicatedKey` cop has been renamed to `Lint/DuplicateHashKey`.
Expand Down