Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have correctors accept node instead of range #7863

Merged
merged 2 commits into from Apr 10, 2020
Merged

Have correctors accept node instead of range #7863

merged 2 commits into from Apr 10, 2020

Commits on Apr 10, 2020

  1. Have correctors accept nodes in addition to ranges. 

    Provide better errors in case of wrong argument
Before: "undefined method `source_buffer' for 1..3:Range"
After: "Expected a Parser::Source::Range or Rubocop::AST::Node, got Range"
    @marcandre
    marcandre committed Apr 10, 2020
    Copy the full SHA
    07f4144 View commit details
    Browse the repository at this point in the history

  2. Simplify now that corrector accept node arguments and/or allow wrap

    @marcandre
    marcandre committed Apr 10, 2020
    Copy the full SHA
    8efed68 View commit details
    Browse the repository at this point in the history