[Fix #7850] Make it possible to enable/disable pending cops #7856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves rubocop#7850. This PR will add `--enable-pending-cops` and `--disable-pending-cops` command-line options and `NewCops` will be provided in .rubocop.yml. When `NewCops` is `enable`, pending cops are enabled in bulk. ```yaml AllCops: NewCops: enable ``` Can be overridden by the `--enable-pending-cops` command-line option. When `NewCops` is `disable`, pending cops are disabled in bulk. ```yaml AllCops: NewCops: disable ``` Can be overridden by the `--disable-pending-cops` command-line option. The default value of `NewCops` is `pending`.
koic
force-pushed
the
add_enable_disable_pending_cops_options
branch
from
d069622
to
544edbf
Compare
|
Fantastic work, @koic! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7850.
This PR will add
--enable-pending-copsand--disable-pending-copscommand-line options andNewCopswill be provided in .rubocop.yml.When
NewCopsisenable, pending cops are enabled in bulk.Can be overridden by the
--enable-pending-copscommand-line option.When
NewCopsisdisable, pending cops are disabled in bulk.Can be overridden by the
--disable-pending-copscommand-line option.The default value of
NewCopsispending.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.