Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#7842] Fix a false positive for Lint/RaiseException #7845

Merged

Conversation

koic
Copy link
Member

@koic koic commented Apr 3, 2020

Resolve part of #7842.

This PR fixes a false positive for Lint/RaiseException when raising Exception with explicit namespace.

Exception belonging to a namespace is expected to inherit StandardError.

This PR makes Lint/RaiseException aware of the following differences:

Gem::Exception.new.is_a?(StandardError) # => true
Exception.new.is_a?(StandardError)      # => false

On the other hand, the following case have not been resolved by this PR.

module Gem
  def self.foo
    raise Exception
  end
end

Gem.foo #=> Gem::Exception

The above case will be resolved separately from this PR.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@koic koic force-pushed the fix_false_positive_for_lint_raise_exception branch from 1498517 to b99b0c9 Compare April 3, 2020 14:53
Resolve part of rubocop#7842.

This PR fixes a false positive for `Lint/RaiseException`
when raising Exception with explicit namespace.

`Exception` belonging to a namespace is expected to
inherit `StandardError`.

This PR makes `Lint/RaiseException` aware of the following differences:

```ruby
Gem::Exception.new.is_a?(StandardError) # => true
Exception.new.is_a?(StandardError)      # => false
```

On the other hand, the following case have not been resolved by this PR.

```ruby
module Gem
  def self.foo
    raise Exception
  end
end

Gem.foo #=> Gem::Exception
```

The above case will be resolved separately from this PR.
@koic koic force-pushed the fix_false_positive_for_lint_raise_exception branch from b99b0c9 to eda5183 Compare April 3, 2020 17:02
@koic koic merged commit 5365e61 into rubocop:master Apr 3, 2020
@koic koic deleted the fix_false_positive_for_lint_raise_exception branch April 3, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant