[Fix #7841] Fix an error for Style/TrailingCommaInBlockArgs cop
#7843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_error_for_style_trailing_comma_in_block_args
branch
from
0c8b2ea
to
f65c0f3
Compare
bbatsov
reviewed
Apr 4, 2020
| @@ -44,6 +44,9 @@ class TrailingCommaInBlockArgs < Cop | |||
| MSG = 'Useless trailing comma present in block arguments.' | |||
|
|
|||
| def on_block(node) | |||
| # lambda literal (`->`) never have a block arguments. | |||
bbatsov
approved these changes
Apr 4, 2020
koic
force-pushed
the
fix_error_for_style_trailing_comma_in_block_args
branch
from
f65c0f3
to
b5e216c
Compare
Fixes rubocop#7841. This PR fixes an error for `Style/TrailingCommaInBlockArgs` cop when lambda literal (`->`) has multiple arguments. It will not be checked in the case of lambda literal because lambda literal (`->`) never have a block arguments. ```console # Valid syntax % ruby -ce '-> (foo, bar) { do_something(foo, bar) }' Syntax OK # Syntax error % ruby -ce '-> { |foo| do_something }' -e:1: syntax error, unexpected '|' -> { |foo| do_something } ^ # Also syntax error % ruby -ce '-> (foo, bar,) { do_something(foo, bar) }' -e:1: syntax error, unexpected ')' -> (foo, bar,) { do_something(foo, bar) } ^ -e:1: syntax error, unexpected '}', expecting end-of-input r,) { do_something(foo, bar) } ^ ```
koic
force-pushed
the
fix_error_for_style_trailing_comma_in_block_args
branch
from
b5e216c
to
6169ce3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7841.
This PR fixes an error for
Style/TrailingCommaInBlockArgscop when lambda literal (->) has multiple arguments. It will not be checked in the case of lambda literal because lambda literal (->) never have a block arguments.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.