New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix #7777, #7776]: Generate valid code if comment present before closing brace #7835
[Fix #7777, #7776]: Generate valid code if comment present before closing brace #7835
Commits on Apr 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4a097d6 - Browse repository at this point
Copy the full SHA 4a097d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8167c38 - Browse repository at this point
Copy the full SHA 8167c38View commit details -
Generate valid code if comment present before closing-brace
Add changes in change log file
Configuration menu - View commit details
-
Copy full SHA for d44e62e - Browse repository at this point
Copy the full SHA d44e62eView commit details
Commits on Apr 2, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 639dacd - Browse repository at this point
Copy the full SHA 639dacdView commit details -
Merge pull request #7840 from yujideveloper/fix/typo
Fix typo in CHANGELOG
Configuration menu - View commit details
-
Copy full SHA for 0f572e8 - Browse repository at this point
Copy the full SHA 0f572e8View commit details
Commits on Apr 3, 2020
-
Merge pull request #7384 from egze/disable_cops_within_source_code_di…
…rective implement Style/DisableCopsWithinSourceCodeDirective cop
Configuration menu - View commit details
-
Copy full SHA for 29b16fd - Browse repository at this point
Copy the full SHA 29b16fdView commit details -
[#7842] Fix a false positive for
Lint/RaiseException
Resolve part of #7842. This PR fixes a false positive for `Lint/RaiseException` when raising Exception with explicit namespace. `Exception` belonging to a namespace is expected to inherit `StandardError`. This PR makes `Lint/RaiseException` aware of the following differences: ```ruby Gem::Exception.new.is_a?(StandardError) # => true Exception.new.is_a?(StandardError) # => false ``` On the other hand, the following case have not been resolved by this PR. ```ruby module Gem def self.foo raise Exception end end Gem.foo #=> Gem::Exception ``` The above case will be resolved separately from this PR.
Configuration menu - View commit details
-
Copy full SHA for eda5183 - Browse repository at this point
Copy the full SHA eda5183View commit details -
Merge pull request #7845 from koic/fix_false_positive_for_lint_raise_…
…exception [#7842] Fix a false positive for `Lint/RaiseException`
Configuration menu - View commit details
-
Copy full SHA for 5365e61 - Browse repository at this point
Copy the full SHA 5365e61View commit details
Commits on Apr 4, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 831a99e - Browse repository at this point
Copy the full SHA 831a99eView commit details -
Merge pull request #7837 from tejasbubane/fix-7834
Fix `Lint/UriRegexp` to register offense with array arguments
Configuration menu - View commit details
-
Copy full SHA for 2ef0e72 - Browse repository at this point
Copy the full SHA 2ef0e72View commit details -
[Fix #7841] Fix an error for
Style/TrailingCommaInBlockArgs
copFixes #7841. This PR fixes an error for `Style/TrailingCommaInBlockArgs` cop when lambda literal (`->`) has multiple arguments. It will not be checked in the case of lambda literal because lambda literal (`->`) never have a block arguments. ```console # Valid syntax % ruby -ce '-> (foo, bar) { do_something(foo, bar) }' Syntax OK # Syntax error % ruby -ce '-> { |foo| do_something }' -e:1: syntax error, unexpected '|' -> { |foo| do_something } ^ # Also syntax error % ruby -ce '-> (foo, bar,) { do_something(foo, bar) }' -e:1: syntax error, unexpected ')' -> (foo, bar,) { do_something(foo, bar) } ^ -e:1: syntax error, unexpected '}', expecting end-of-input r,) { do_something(foo, bar) } ^ ```
Configuration menu - View commit details
-
Copy full SHA for 6169ce3 - Browse repository at this point
Copy the full SHA 6169ce3View commit details -
Merge pull request #7843 from koic/fix_error_for_style_trailing_comma…
…_in_block_args [Fix #7841] Fix an error for `Style/TrailingCommaInBlockArgs` cop
Configuration menu - View commit details
-
Copy full SHA for 28f18ac - Browse repository at this point
Copy the full SHA 28f18acView commit details -
[Fix #6963] Check if iterating through Enumerator created with value …
…returning method
Tomek Urban committedApr 4, 2020 Configuration menu - View commit details
-
Copy full SHA for 9e47db3 - Browse repository at this point
Copy the full SHA 9e47db3View commit details
Commits on Apr 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 87613a2 - Browse repository at this point
Copy the full SHA 87613a2View commit details