[Fix #7831] Fix a false positive for Style/HashEachMethods
#7832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_false_positive_for_style_hash_each_methods
branch
from
8195e23
to
15f755f
Compare
Fixes rubocop#7831. This PR fix a false positive for `Style/HashEachMethods` when there is no receiver for `keys` and `values`. The following is an examples. ```ruby values.each { |k, v| do_something(k, v) } keys.each { |k, v| do_something(k, v) } ``` False negatives occur in cases such as object that inherit Hash, but that is perhaps a corner case. I think it is more worthwhile to resolve the false positives with common naming of `values`.
koic
force-pushed
the
fix_false_positive_for_style_hash_each_methods
branch
from
15f755f
to
3d63c6d
Compare
|
Good change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7831.
This PR fix a false positive for
Style/HashEachMethodswhen there is no receiver forkeysandvalues.The following is an examples.
False negatives occur in cases such as object that inherit Hash, but that is perhaps a corner case.
I think it is more worthwhile to resolve the false positives with common naming of
values.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.