[Fix #7814] Fix a false positive for Migrate/DepartmentName cop
#7818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_a_false_positive_for_migrate_department_name
branch
from
1aca11f
to
489d2ab
Compare
### Summary Fixes rubocop#7814. This PR fixes a false positive for `Migrate/DepartmentName` cop when inspecting an unexpected disable comment format. e.g. `# rubocop:disable Style:BlockComments` The above expected format is `# rubocop:disable Style/BlockComments`. ### Other Information `Migration/DepartmentName` cop's role is to complement a department name. The role would be simple if another feature could detect unexpected disable comment format.
koic
force-pushed
the
fix_a_false_positive_for_migrate_department_name
branch
from
489d2ab
to
cf3a020
Compare
|
Nicely done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7814.
This PR fixes a false positive for
Migrate/DepartmentNamecop when inspecting an unexpected disabled comment format.e.g.
# rubocop:disable Style:BlockCommentsThe above expected format is
# rubocop:disable Style/BlockComments.Other Information
Migration/DepartmentNamecop's role is to complement a department name.The role would be simple if another feature could detect unexpected disable comment format.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.