[Fix #7795] Make Layout/EmptyLineAfterGuardClause aware of and return
#7796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
make_empty_line_after_guard_clause_aware_of_and_return
branch
from
066c001
to
4007253
Compare
Drenmi
approved these changes
Mar 13, 2020
koic
force-pushed
the
make_empty_line_after_guard_clause_aware_of_and_return
branch
from
4007253
to
e191613
Compare
Drenmi
reviewed
Mar 13, 2020
koic
force-pushed
the
make_empty_line_after_guard_clause_aware_of_and_return
branch
from
26467b6
to
c281156
Compare
Drenmi
approved these changes
Mar 13, 2020
|
@Drenmi Thanks for your kindness review! |
|
Shouldn't we also cover usages of |
koic
force-pushed
the
make_empty_line_after_guard_clause_aware_of_and_return
branch
from
c281156
to
3e7cd7e
Compare
|
Sure! I updated this PR to support |
|
@koic Looks good! Feel free to merge it and the other PRs I just approved. I was a bit too lazy to resolve the merge conflicts in the changelog myself. :-) |
|
Yeah, I will resolve conflicts and merge. Thank you for the review! |
…and return` Resolves rubocop#7795. This PR makes `Layout/EmptyLineAfterGuardClause` aware of `and return`. It was proposed based on the following code controlled by Rails controller. ```ruby render :foo and return if condition do_something ``` I think that it can be generalized as a control flow. ```ruby foo(arg) and return if condition do_something ``` So it will be newly detected by `Layout/EmptyLineAfterGuardClause` cop.
koic
force-pushed
the
make_empty_line_after_guard_clause_aware_of_and_return
branch
from
3e7cd7e
to
2e9f9e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7795.
This PR makes
Layout/EmptyLineAfterGuardClauseaware ofand return.It was proposed based on the following code controlled by Rails controller.
I think that it can be generalized as a control flow.
So it will be newly detected by
Layout/EmptyLineAfterGuardClausecop.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.