[Fix #7778] Fix a false positive for Layout/EndAlignment
#7794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
approved these changes
Mar 19, 2020
Resolves rubocop#7778. This PR resolves a false positive for `Layout/EndAlignment` when a non-whitespace is used before the `end` keyword. ```console % cat example.rb if cond else 'foo' end % bundle exec rubocop -a --only Layout/EndAlignment (snip) Inspecting 1 file W Offenses: example.rb:2:12: W: Layout/EndAlignment: end at 2, 11 is not aligned with if at 1, 0. else 'foo' end ^^^ 1 file inspected, 1 offense detected ``` This PR changes to not offense it. I think the responsibility will be clear if different (maybe new) cop like `Layout/BlockEndNewline` cop handle the offense case. So I think this role is preferably separated by `Layout/EndAlignment` cop.
koic
force-pushed
the
fix_a_false_positive_for_end_keyword_alignment
branch
from
f171472
to
4bfe82e
Compare
|
Thanks @koic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7778.
This PR resolves a false positive for
Layout/EndAlignmentwhen a non-whitespace is used before theendkeyword.This PR changes to not offense it.
I think the responsibility will be clear if different (maybe new) cop like
Layout/BlockEndNewlinecop handle the offense case.So I think this role is preferably separated by
Layout/EndAlignmentcop.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.