Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #7779] Fix a false positive for Style/MultilineMethodCallIndentation #7782

Merged
merged 2 commits into from Mar 7, 2020
Merged

[Fix #7779] Fix a false positive for Style/MultilineMethodCallIndentation #7782

merged 2 commits into from Mar 7, 2020

Conversation

koic
Copy link
Member

@koic koic commented Mar 7, 2020

Fixes #7779.

This PR fixes a false positive for Style/MultilineMethodCallIndentation when using Ruby 2.7's numbered parameter.

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

koic and others added 2 commits March 8, 2020 01:00
@koic
[Fix rubocop#7779] Fix a false positive for `Style/MultilineMethodCal…
d8bdede 
…lIndentation`

Fixes rubocop#7779.

This PR fixes a false positive for `Style/MultilineMethodCallIndentation`
when using Ruby 2.7's numbered parameter.
@bbatsov
Merge branch 'master' into fix_false_positive_for_multiline_method_ca…
100a012 
…ll_indentation
@bbatsov bbatsov merged commit e9e0482 into rubocop:master Mar 7, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Mar 7, 2020

Thanks!

@koic koic deleted the fix_false_positive_for_multiline_method_call_indentation branch March 7, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layout/MultilineMethodCallIndentation reports false positives if using Ruby 2.7 numbered parameters
2 participants
@koic @bbatsov