[Fix #7740] Make Style/AccessModifierDeclarations not flag symbol method-name

[tejasbubane]

Closes #7740

---

Before submitting the PR make sure the following are checked:

• Wrote good commit messages.
• Commit message starts with [Fix #issue-number] (if the related issue exists).
• Feature branch is up-to-date with master (if not - rebase it).
• Squashed related commits together.
• Added tests.
• Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
• The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
• Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

[bbatsov]

The cop documentation should definitely be updated to reflect this.

I think we also need some flag to enable/disable this, as if you're using modifiers in this manner, you're potentially violating grouping/non-grouping. That's why I'd prefer having more control over the behaviour.

[tejasbubane]

@bbatsov Fixed to use node-matcher instead of explicit checks.

Regarding flag to turn this feature off, do you think the following configs make sense?

1. group (default) - forbids inline method definition but allows inline symbol
2. strict_group - forbids inline method definition & symbols
3. inline - all modifiers should be inline

Let me know if you have something else in mind.

[mintyfresh]

@tejasbubane
The act of allowing inline-symbol seems tangential to the modes of group and inline, since those refer to definition style, whereas referencing a Symbol is used for existing declarations.

Maybe it might make more sense to have it be a flag?
Allowing or forbidding the inline-Symbol behaviour could be applicable regardless of whether the preferred definition style is inline or group.

An argument could even be made to put it under a separate rule (ie. Style/AccessModifierChange or similar) but that might be overkill.

[bbatsov]

Maybe it might make more sense to have it be a flag?

Exactly. This shouldn't be a style, it should a flag that affects both styles - something like AllowModifiersOnSymbols or whatever. A better name would be welcome. :-)

[tejasbubane]

@bbatsov I added config option to AllowModifiersOnSymbols.

[bbatsov]

I'd also extend the cop documentation to mention that it covers only definitions and applications of visibility methods to symbols are controlled by the new config.

[tejasbubane]

I'd also extend the cop documentation to mention that it covers only definitions and applications of visibility methods to symbols are controlled by the new config.

Added.

[bbatsov]

Thanks!