[Fix #7745] Suppress pending cop warnings when department is disabled #7758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
suppress_pending_cop_warnings_when_deaprtment_is_disabled
branch
from
424bf77
to
2caa627
Compare
…isabled Fixes rubocop#7745. This PR suppresses a pending cop warnings when pending cop's department is disabled. ## Context ```console % rubocop -V 0.80.0 (using Parser 2.7.0.2, running on ruby 2.7.0 x86_64-darwin17) ``` ```yaml % cat .rubocop.yml Style: Enabled: false ``` ## Before The following pending cop warning is displayed for disabled Style department. ```console % bundle exec rubocop The following cops were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file: - Style/HashEachMethods - Style/HashTransformKeys - Style/HashTransformValues Inspecting 0 files 0 files inspected, no offenses detected ``` ## After A pending cop warning is not displayed for disabled Style department. ```console % bundle exec rubocop Inspecting 0 files 0 files inspected, no offenses detected ```
koic
force-pushed
the
suppress_pending_cop_warnings_when_deaprtment_is_disabled
branch
from
2caa627
to
d0321b7
Compare
|
Nicely done! 🙇 |
koic
deleted the
suppress_pending_cop_warnings_when_deaprtment_is_disabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7745.
This PR suppresses a pending cop warnings when pending cop's department is disabled.
Context
Before
The following pending cop warning is displayed for disabled Style department.
After
A pending cop warning is not displayed for disabled Style department.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.