Add VersionAdded to Style/HashTransformKeys, Style/HashTransformValues
#7757
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
reviewed
Feb 25, 2020
This PR added `VersionAdded` to `Style/HashTransformKeys` and `Style/HashTransformValue`. This Cops was added at rubocop#7663 and published at 0.80.0.
n0h0
force-pushed
the
add-versionadded-to-hash-transform
branch
from
43e72e7
to
8fbe934
Compare
|
@koic |
|
Thanks! |
|
We should add the version that the cop was added in to the pending cops warning, so it's easier to figure out which cop came from which release (I doubt all users update after each release). This will also make it easier to stop issues like this one, although eventually we should start checking for missing version in the CI. |
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
Feb 29, 2020
Follow up of rubocop#7757 (comment). When warning about a pending cop, this PR displays the version with the cop added. ## Before ```console % rubocop The following cops were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file: - Style/HashEachMethods - Style/HashTransformKeys - Style/HashTransformValues ``` ## After ```console % rubocop The following cops were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file: - Style/HashEachMethods (0.80) - Style/HashTransformKeys (0.80) - Style/HashTransformValues (0.80) For more information: https://docs.rubocop.org/en/latest/versioning/ ```
bbatsov
pushed a commit
that referenced
this pull request
Feb 29, 2020
Follow up of #7757 (comment). When warning about a pending cop, this PR displays the version with the cop added. ## Before ```console % rubocop The following cops were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file: - Style/HashEachMethods - Style/HashTransformKeys - Style/HashTransformValues ``` ## After ```console % rubocop The following cops were added to RuboCop, but are not configured. Please set Enabled to either `true` or `false` in your `.rubocop.yml` file: - Style/HashEachMethods (0.80) - Style/HashTransformKeys (0.80) - Style/HashTransformValues (0.80) For more information: https://docs.rubocop.org/en/latest/versioning/ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added
VersionAddedtoStyle/HashTransformKeysandStyle/HashTransformValue.This Cops was added at #7663 and published at 0.80.0.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.