Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #7739] Allow methods raising NotImplementedError in Lint/UnusedMethodArgument #7747

Merged
merged 1 commit into from Mar 22, 2020

Conversation

tejasbubane
Copy link
Contributor

Closes #7739


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@bbatsov
Copy link
Collaborator

bbatsov commented Mar 21, 2020

Apart from my small remarks I'm fine with the proposed changes.

@bbatsov
Copy link
Collaborator

bbatsov commented Mar 22, 2020

Thanks!

@tejasbubane tejasbubane deleted the fix-7739 branch March 22, 2020 09:36
@sandstrom
Copy link

@tejasbubane Awesome addition!

What do you think about Lint/UnreachableCode having this check too?

Basically such that it would allow:

def my_method
  raise NotImplementedError
  
  1 + 1
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow unused variables when a class method only raises a NotImplementedError
3 participants