Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #7682] Fix Style/InverseMethods autofix leaving parenthesis #7732

Merged
merged 1 commit into from Feb 22, 2020
Merged

[Fix #7682] Fix Style/InverseMethods autofix leaving parenthesis #7732

merged 1 commit into from Feb 22, 2020

Conversation

tejasbubane
Copy link
Contributor

Closes #7682

Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

@tejasbubane tejasbubane force-pushed the fix-7682 branch 2 times, most recently from 847086c to 458fd62 Compare February 19, 2020 08:35
koic
koic approved these changes Feb 22, 2020
View reviewed changes
Copy link
Member

@koic koic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Can you rebase with the latest master branch?

@tejasbubane
Copy link
Contributor Author

@koic Rebased.

@koic koic merged commit 287cad4 into rubocop:master Feb 22, 2020
@koic
Copy link
Member

koic commented Feb 22, 2020

Thanks!

@tejasbubane tejasbubane deleted the fix-7682 branch February 23, 2020 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koic koic koic approved these changes

@rrosenblum rrosenblum rrosenblum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Style/InverseMethods autofix leaves a parenthesis
3 participants
@tejasbubane @koic @rrosenblum