Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate dependency development gem #7703

Merged

Conversation

koic
Copy link
Member

@koic koic commented Feb 11, 2020

This PR suppress the following warning.

% cd path/to/rubocop
% bundle install
Your Gemfile lists the gem pry (>= 0) more than once.
You should probably keep only one of them.
Remove any duplicate entries and specify the gem only once.
While it's not a problem now, it could cause errors if you change the
version of one of them later.
Using rake 12.3.3
Using public_suffix 4.0.3

(snip)

pry gem is already in the Gemfile.
This looks like it was accidentally added in #7663.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This PR suppress the following warning.

```console
% cd path/to/rubocop
% bundle install
Your Gemfile lists the gem pry (>= 0) more than once.
You should probably keep only one of them.
Remove any duplicate entries and specify the gem only once.
While it's not a problem now, it could cause errors if you change the
version of one of them later.
Using rake 12.3.3
Using public_suffix 4.0.3

(snip)
```

`pry` gem is already in the Gemfile.
This looks like it was accidentally added in rubocop#7663.
@bbatsov bbatsov merged commit 266c4c3 into rubocop:master Feb 11, 2020
@bbatsov
Copy link
Collaborator

bbatsov commented Feb 11, 2020

Thanks!

@koic koic deleted the remove_duplicated_dependency_development_gem branch February 11, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants